Re: linux-next: Tree for Feb 15 (CXL on i386)

From: Randy Dunlap
Date: Mon Feb 15 2021 - 12:49:20 EST


On 2/15/21 1:34 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20210212:
>


CXL on i386 has these issue:

../drivers/cxl/mem.c:335:2: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
writeq(cmd_reg, cxlm->mbox_regs + CXLDEV_MBOX_CMD_OFFSET);
^~~~~~

../drivers/cxl/mem.c:350:15: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
status_reg = readq(cxlm->mbox_regs + CXLDEV_MBOX_STATUS_OFFSET);


and lots of these (just one example here):

../drivers/cxl/cxl.h:29:47: note: in expansion of macro ‘GENMASK’
#define CXLDEV_MBOX_CMD_PAYLOAD_LENGTH_MASK GENMASK(36, 16)
^~~~~~~
../drivers/cxl/mem.c:329:25: note: in expansion of macro ‘CXLDEV_MBOX_CMD_PAYLOAD_LENGTH_MASK’
cmd_reg |= FIELD_PREP(CXLDEV_MBOX_CMD_PAYLOAD_LENGTH_MASK,
^
../include/linux/bits.h:36:11: warning: right shift count is negative [-Wshift-count-negative]
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^
../include/linux/bitfield.h:95:49: note: in definition of macro ‘FIELD_PREP’
((typeof(_mask))(_val) << __bf_shf(_mask)) & (_mask); \
^~~~~
../include/linux/bits.h:38:31: note: in expansion of macro ‘__GENMASK’
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
^~~~~~~~~


--
~Randy
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>