Re: [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam()

From: David Miller
Date: Mon Feb 15 2021 - 15:58:38 EST


From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 15 Feb 2021 18:56:46 +0300

> The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX".
>
> I did some cleanup in this function to hopefully make the code a bit
> clearer. There was no blank line after the declaration block. The
> closing curly brace on the fec[] declaration normally goes on a line
> by itself. And I removed the FEC_MAX_INDEX define and used
> ARRAY_SIZE(fec) instead.
>
> Fixes: d0cf9503e908 ("octeontx2-pf: ethtool fec mode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

This doesn't apply to net-next.