Re: [PATCH v2] fs: ubifs: set s_uuid in super block to support ima/evm uuid options

[Andy Shevchenko]

On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@xxxxxxxxxxxxxx> wrote:
>
> From: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
>
> This is required to provide uuid based integrity functionality for:
> ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option).

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
One issue below has to be addressed nevertheless.

> Co-developed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Co-developed-by: Juergen Borleis <jbe@xxxxxxxxxxxxxx>

According to the documentation [1] above has two issues:
- all Co-developed-by *must* be accompanied with corresponding SoBs
- commiter must provide his SoB (but it will be implied by the
previous requirement in this case)

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
>  fs/ubifs/super.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 138b9426c6c1..a8383ca39a47 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
>                 goto out_umount;
>         }
>
> +       import_uuid(&sb->s_uuid, c->uuid);
> +
>         mutex_unlock(&c->umount_mutex);
>         return 0;
>
> --
> 2.20.1
>


-- 
With Best Regards,
Andy Shevchenko