Re: [PATCH V0 1/6] dt-bindings: Added the yaml bindings for DCC

[schowdhu]

On 2021-02-17 16:32, Vinod Koul wrote:
> On 17-02-21, 12:18, Souradeep Chowdhury wrote:
> > Documentation for Data Capture and Compare(DCC) device tree bindings
> > in yaml format.
> >
> > Signed-off-by: Souradeep Chowdhury <schowdhu@xxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/arm/msm/qcom,dcc.yaml      | 49 
> > ++++++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml 
> > b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> > new file mode 100644
> > index 0000000..8f09578
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Data Capture and Compare
> > +
> > +maintainers:
> > +  - Souradeep Chowdhury <schowdhu@xxxxxxxxxxxxxx>
> > +
> > +description: |
> > +    DCC (Data Capture and Compare) is a DMA engine which is used to 
> > save
> > +    configuration data or system memory contents during catastrophic 
> > failure
> > +    or SW trigger.DCC is used to capture and store data for debugging 
> > purpose
>
> space after .

Ack

> > +
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +    - enum:
> > +      - qcom,sm8150-dcc
> > +    - const: qcom,dcc
> > +
> > +  reg:
> > +    items:
> > +      - description: DCC base register region
> > +      - description: DCC RAM base register region
> > +
> > +  reg-names:
> > +    items:
> > +      - const: dcc-base
> > +      - const: dcc-ram-base
>
> drop dcc from names

Since DCC has a dedicated SRAM, this has been named like this as
only base and ram-base are generic names. Let me know if this is
still required to be changed.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reg-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    dcc@010a2000{
> > +                compatible = "qcom,sm8150-dcc";
>
> should this not be:
>                 compatible = "qcom,sm8150-dcc", "qcom,dcc";

Ack

> > +                reg = <0 0x010a2000 0  0x1000>,
> > +                      <0 0x010ae000 0  0x2000>;
> > +                reg-names = "dcc-base", "dcc-ram-base";
> > +    };
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
> > member
> > of Code Aurora Forum, hosted by The Linux Foundation