Re: [PATCH v2 3/3] crypto: hisilicon/sec - fixes shash test error

[liulongfang]

On 2021/2/10 14:43, Herbert Xu Wrote:
> On Sun, Feb 07, 2021 at 06:04:40PM +0800, Longfang Liu wrote:
>> If the header file "crypto/internal/hash.h" not
>> added, the allocation of crypto_tfm will fail when
>> the shash algorithm calculates the hash
>> through the software.
>>
>> Signed-off-by: Longfang Liu <liulongfang@xxxxxxxxxx>
>> ---
>>  drivers/crypto/hisilicon/sec2/sec_crypto.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c
>> index d2c4a2c..988faf7 100644
>> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c
>> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c
>> @@ -7,6 +7,7 @@
>>  #include <crypto/des.h>
>>  #include <crypto/hash.h>
>>  #include <crypto/internal/aead.h>
>> +#include <crypto/internal/hash.h>
> 
> Please explain what exactly in this file needs this header file.
> 
> As it stands you could just be hiding real bugs.
> 
> Thanks,
> 
The crypto_alloc_shash() interface in the header file
will be used in the function sec_aead_ctx_init(),
If this header file is not added, calling the interface
crypto_alloc_shash() during the initialization of the
aead algorithm will return an error.
Thanks,