RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

From: Min Li
Date: Wed Feb 17 2021 - 22:31:07 EST




> -----Original Message-----
> From: Arnd Bergmann <arnd@xxxxxxxxxx>
> Sent: February 17, 2021 4:30 PM
> To: Min Li <min.li.xe@xxxxxxxxxxx>
> Cc: Derek Kiernan <derek.kiernan@xxxxxxxxxx>; Dragan Cvetic
> <dragan.cvetic@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; gregkh
> <gregkh@xxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Networking
> <netdev@xxxxxxxxxxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>
> Subject: Re: [PATCH net-next] misc: Add Renesas Synchronization
> Management Unit (SMU) support
>
> On Wed, Feb 17, 2021 at 9:20 PM Min Li <min.li.xe@xxxxxxxxxxx> wrote:
> >
> > I attached the G.8273.2 document, where chapter 6 is about supporting
> > physical layer frequency. And combo mode is Renesas way to support
> > this requirement. Other companies may come up with different ways to
> support it.
> >
> > When EEC quality is below certain level, we would wanna turn off combo
> mode.
>
> Maybe this is something that could be handled inside of the device driver
> then?
>
> If the driver can use the same algorithm that is in your user space software
> today, that would seem to be a nicer way to handle it than requiring a
> separate application.
>

Hi Arnd


What is the device driver that you are referring here?

In summary of your reviews, are you suggesting me to discard this change and go back to PTP subsystem
to find a better place for things that I wanna do here?

Min