Re: [PATCH net-next] net: mscc: Fix MRP switchdev driver

[Vladimir Oltean]

Hi Horatiu,

On Thu, Feb 18, 2021 at 12:47:26PM +0100, Horatiu Vultur wrote:
> This patch fixes the ocelot MRP switchdev driver such that also DSA
> driver can use these functions. Before the driver presumed that the
> net_device uses a 'struct ocelot_port_private' as priv which was wrong.
> 
> The only reason for using ocelot_port_private was to access the
> net_device, but this can be passed as an argument because we already
> have this information. Therefore update the functions to have also the
> net_device parameter.
> 
> Fixes: a026c50b599fa ("net: dsa: felix: Add support for MRP")
> Fixes: d8ea7ff3995ea ("net: mscc: ocelot: Add support for MRP")
> Reported-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> 
> ---

Do you mind if we drop this patch for now (the net-next pull request was
already sent) and I will ensure that the MRP assist for Felix DSA works
properly when I find the time to compile your mrp/cfp user space
packages and give them a try?

There are more issues to be fixed than your patch addresses. For
example, MRP will only work with the NPI-based tagging protocol,
somebody needs to reject MRP objects when ocelot-8021q is in use.
I think it's better for someone who has access to a DSA setup to ensure
that the driver is in a reasonable state.

Sorry for not reviewing the MRP patches in time.