Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

[Suzuki K Poulose]

On 2/18/21 2:30 PM, Mike Leach wrote:
> HI Suzuki,
>
> On Thu, 18 Feb 2021 at 07:50, Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote:
> > Hi Mike
> >
> > On 2/16/21 9:00 AM, Mike Leach wrote:
> > > Hi Anshuman,
> > >
> > > There have been plenty of detailed comments so I will restrict mine to
> > > a few general issues:-
> > >
> > > 1) Currently there appears to be no sysfs support (I cannot see the
> > > MODE_SYSFS constants running alongside the MODE_PERF ones present in
> > > the other sink drivers). This is present on all other coresight
> > > devices, and must be provided for this device. It is useful for
> > > testing, and there are users out there who will have scripts to use
> > > it. It is not essential it makes it into this set, but should be a
> > > follow up set.
> >
> > This is mentioned in the cover-letter and as you rightly said
> > we could add this in a later series.
>
> Yes - I see that it was mentioned at the end as an open question - so
> I guess this is my answer!
>
> > > 2) Using FILL mode for TRBE means that the trace will by definition be
> > > lossy. Fill mode will halt collection without cleanly stopping and
> > > flushing the source. This will result in the sink missing the last of
> > > the data from the source as it stops. Even if taking the exception
> > > moves into a prohibited region there is still the possibility the last
> > > trace operations will not be seen. Further it is possible that the
> >
> > Correct.
> >
> > > last few bytes of trace will be an incomplete packet, and indeed the
> > > start of the next buffer could contain incomplete packets too.
> >
> > Yes, this is possible.
> >
> > > This operation differs from the other sinks which will only halt after
> > > the sources have stopped and the path has been flushed. This ensures
> > > that the latest trace is complete. The weakness with the older sinks
> > > is the lack of interrupt meaning buffers were frequently wrapped so
> > > that only the latest trace is available.
> >
> > This is true, when there was no overflow. i.e, we follow the normal
> > source-stop-flush, sink-stop.
> >
> > > By using TRBE WRAP mode, with a watermark as described in the TRBE
> > > spec, using the interrupts it is possible to approach lossless trace
> > > in a way that is not possible with earlier ETR/ETB. This is something
> >
> > It may be possible to do lossless trace, but not without double buffering
> > in perf mode. In perf mode, with a single buffer, we have to honor the
> > boundaries set by the aux_buffer head and tail, otherwise we could be
> > corrupting the trace being consumed by the userland.
> >
> > Please remember that the "water mark" is considered as the END of the
> > buffer by TRBE (unlike the SoC-600 ETR). So the LIMIT pointer could be
> > one of :
> >
> >     * Tail pointer ( of the handle space, <=  End_of_the_Buffer)
> >     * Wake up pointer ( when the userspace would like to be woken up ,<= End_of_the_Buffer)
> >
> > So, if we use WRAP mode for perf, the TRBE would overwrite the from
> > the Base, after we hit the LIMIT, where we should have started
> > writing *after* the LIMIT (when LIMIT < End_of_the_Buffer). Moreover
> > restarting from the Base is going to be even more trouble some
> > as it is most likely the data, perf is still collecting.
>
> I agree that the TRBE must write inbetween head and tail / wakeup.
> Howver, there is no reason that I can see why the trbe_base register
> has to remain constant @ the start of the vmapped aux buffer.
> A valid trbe write buffer could be set by:
> trbe_base >= head (rounded up to page boundary)
> trbe_limit <= min(tail, wakeup) (rounded down to page boundary)
> trbe_write is then trbe_base + "watermark" offset. - as suggested in
> the TRBE spec.

The problem is we are dealing with separate entities. The producer
and the consumer are separate entities playing with a single,
infinite running ring buffer. Had this been a double buffering scheme,
this would work really nice. In fact, I had some plans to do this for
SoC-600 ETR.

Coming back, with the proposed approach :

head         write (watermark)          end-of-real buffer
  /          |
 ^---v-------^----------v---------------|
    /                    \
base(aligned)            limit (wakeup/tail)

In this case, assuming single shared buffer, the TRBE would start
writing from "write" watermark and WRAP at limit, going back to base.

The issues here are :
  - If there were no overflow, we cant update the AUX handle
    unless we pad from head to write (which might be significant).

 If there was overflow :
  - You have wrongly ordered data. i.e, the older trace is at "write"
and newer trace is at "base". Unless we copy the data written from
base to the end of "limit", the userspace can't consume it. Or else
it thinks the data at base is older and this gets the trace decoding
gone for a toss.

As you can see, two players dealing with a single buffer doesn't allow
for the kind of flow possible with WRAP.

On the other hand this works perfectly with double buffering. We could
copy the data from the "write" to limit, followed by from "base" to the
current write ptr. This could well be used for sysfs, but since we
have asynchronous collection, we don't need the interrupt and thus
fall back to CIRCULAR_BUFFER mode.

> The issue then becomes unravelling the buffer. Given what we know now,
> and the work on aux buffers, I would suggest that we can easily insert
> meta data to do this in the front of the buffer, saving any trace
> overwirtten at the end of the buffer, and setting a new flag in the
> aux buffer to tell userspace decode to sort it out. Thus the only copy
> needed is in the region of 8 bytes perhaps.
>
> Of course there are potential inefficiencies here in usage of buffer
> space, and yes we cannot guarantee lossless trace, but FILL mode
> guarantees lossy trace and a truncated buffer for every time it wraps
> (by definition, if FILL mode wraps then you cannot be sure that you
> have all the possible trace so it has to be marked as truncated in the
> same way we mark wrapped ETR buffers as truncated whenever they are
> wrapped).
>
> > > that has been requested by partners since trace became available in
> > > linux systems. (There is still a possibility of loss due to filling
> > > the buffer completely and overflowing the watermark, but that can be
> > > flagged).
> > >
> > > While FILL mode trace is a good start, and suitable for some scenarios
> > > - WRAP mode needs implementing as well.
> >
> > Using WRAP mode makes sense only in the case of double buffering. Even
> > with that, we are not guaranteed that we wouldn't loose trace data, with
> > significantly larger buffer than the AUX buffer. So this may not be the
> > right choice looking at the performance and the software expectations.
> >
> > When it comes to sysfs mode, I believe we could use the CIRCULAR_BUFFER
> > mode, as the collection is asynchronous.
>
> Agreed - this makes the most sense here.
>
> > I understand WRAP is suitable
> > for lossless collection, but unfortunately the Linux sof
>
> sentence unexpectedly truncated?!

Sorry, needed some more coffee after the break :-). It should have been :

"... but unfortunately the Linux software semantics (especially perf)
doesn't make this any better usable than the FILL mode".

Cheers
Suzuki