Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform

From: Dan Carpenter
Date: Fri Feb 19 2021 - 02:06:45 EST


On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@xxxxxxxxxxxxxx>
> ---
>
> The preferred coding style is:
> if (!StaAddr)
> return;

Above the Signed-off-by line. Also indenting is wrong. And it's hard
to understand what you're saying.

>
> thank you mr. dan carpenter

You're welcome. (These sorts of comments do go below the --- cut off
line so that's fine.)

regards,
dan carpenter