Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

[Aaron Ma]

On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote:
> > On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
> > > On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
> > > > On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma <aaron.ma@xxxxxxxxxxxxx> wrote:
> > > > > On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
> > > > > > Can you please test the following patch, which should address the root cause:
> > > > > > https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@xxxxxxxxxx/
> > > > > >
> > > > > > It also helps another AMD laptop on S5:
> > > > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935
> > > > >
> > > > > No, this patch doesn't help on ThinkPad AMD platform.
> > > >
> > > > Thanks for the confirmation!
> > > >
> > > > Acked-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> > >
> > > Mathias, want me to take this in my tree now, or are you going to send
> > > me more patches for 5.12-rc1?
> >
> > Nothing more for 5.12-rc1 from me.
> >
> > Could this be a PCI quirk instead of xhci?
> > Maybe there is some PCI flag for this already, haven't checked yet.
> >
> > We want a specific PCI device to go to PCI D3cold at PCI shutdown...
>
> There probably is.  Kay-Heng, can you look into doing that instead?

There is no such PCI quirk, usually it calls driver to shutdown.

Regards,
Aaron

> thanks,
>
> greg k-h