Re: [PATCH v1 6/7] leds: lp50xx: Add missed bits.h and convert to BIT()
From: Andy Shevchenko
Date: Fri Feb 19 2021 - 08:44:10 EST
On Fri, Feb 19, 2021 at 12:27:55PM +0100, Pavel Machek wrote:
> Hi!
>
> > Add missed bits.h and convert to BIT() in lp50xx_set_banks().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Thanks,
Thanks!
> I applied whole series except this one...
>
> << is well known C, it can stay.
Shall we drop BIT() in the other place?
Otherwise it is inconsistency.
--
With Best Regards,
Andy Shevchenko