Re: [PATCH v2 1/5] keys: cleanup build time module signing keys

[Stefan Berger]

On 2/18/21 5:00 PM, Nayna Jain wrote:
> The "mrproper" target is still looking for build time generated keys in
> the old path instead of certs/ directory. Fix the path and remove the
> names of the files which are no longer generated.
>
> Fixes: fb1179499134 ("modsign: Use single PEM file for autogenerated key")
> Signed-off-by: Nayna Jain <nayna@xxxxxxxxxxxxx>

The actual move of the certs files happened in cfc411e7fff3e15. That may 
be the better commit to mention.

Otherwise:

Reviewed-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>


> ---
>   Makefile | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index de1acaefe87e..004163a4e6b3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1472,9 +1472,9 @@ MRPROPER_FILES += include/config include/generated          \
>   		  debian snap tar-install \
>   		  .config .config.old .version \
>   		  Module.symvers \
> -		  signing_key.pem signing_key.priv signing_key.x509	\
> -		  x509.genkey extra_certificates signing_key.x509.keyid	\
> -		  signing_key.x509.signer vmlinux-gdb.py \
> +		  certs/signing_key.pem certs/signing_key.x509 \
> +		  certs/x509.genkey \
> +		  vmlinux-gdb.py \
>   		  *.spec
>   
>   # Directories & files removed with 'make distclean'