Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning

From: Dan Carpenter
Date: Fri Feb 19 2021 - 12:16:14 EST


On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
>

These comments need to go below the --- cut off line.

> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <fuzzybritches@xxxxxxxxxxxxxx>
> ---
^^^

This one here.

> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

regards,
dan carpenter