Re: [PATCH v5 01/22] media: camss: Fix vfe_isr_comp_done() documentation

From: Nicolas Dufresne
Date: Fri Feb 19 2021 - 16:06:51 EST


Hi Robert,

not really a review, but I noticed ....

Le mercredi 17 février 2021 à 12:21 +0100, Robert Foss a écrit :
> Function name is comment is wrong, and was changed to be

in

> the same as the actual function name.
>
> The comment was changed to kerneldoc format.
>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> ---
>
> Changes since v1
>  - Bjorn: Fix function doc name & use kerneldoc format
>
>
>  drivers/media/platform/qcom/camss/camss-vfe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c
> b/drivers/media/platform/qcom/camss/camss-vfe.c
> index fae2b513b2f9..94c9ca7d5cbb 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -1076,8 +1076,8 @@ static void vfe_isr_wm_done(struct vfe_device *vfe, u8
> wm)
>         spin_unlock_irqrestore(&vfe->output_lock, flags);
>  }
>  
> -/*
> - * vfe_isr_wm_done - Process composite image done interrupt
> +/**
> + * vfe_isr_comp_done() - Process composite image done interrupt
>   * @vfe: VFE Device
>   * @comp: Composite image id
>   */