Re: [RFC][PATCH 6/6] objtool,x86: Rewrite retpoline thunk calls

From: Peter Zijlstra
Date: Fri Feb 19 2021 - 17:07:48 EST


On Fri, Feb 19, 2021 at 03:55:30PM -0600, Josh Poimboeuf wrote:
> On Fri, Feb 19, 2021 at 09:43:06PM +0100, Peter Zijlstra wrote:
> > Arguably it would be simpler to do the other way around, but
> > unfortunately alternatives don't work that way, we cannot say:
> >
> > ALTERNATIVE "call __x86_indirect_thunk_\reg",
> > "call *%reg", ~X86_FEATURE_RETPOLINE
> >
> > That is, there is no negative form of alternatives.
>
> X86_FEATURE_NO_RETPOLINE?

We could, but it so happens Joerg is also wanting negative features. So
I was thikning that perhaps we can convince Boris they're not really all
that aweful after all :-)