Re: [PATCH 3/9] security: keys: trusted: Parse out individual components of the key blob

From: Jarkko Sakkinen
Date: Fri Feb 19 2021 - 22:06:36 EST


On Sat, Feb 20, 2021 at 01:32:49AM +0000, Matthew Garrett wrote:
> Performing any sort of state validation of a sealed TPM blob requires
> being able to access the individual members in the response. Parse the
> blob sufficiently to be able to stash pointers to each member, along
> with the length.
>
> Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxx>

I'll just say LGTM for now. Did not see anything obviously wrong in
the code change (and does make sense to nitpick minor things just
yet).

Need to understand the whole use case just a little bit better.

/Jarkko