Re: [PATCH] video: fbdev: pm2fb: avoid stall on fb_sync

[kernel test robot]

Hi Tong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.11 next-20210219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tong-Zhang/video-fbdev-pm2fb-avoid-stall-on-fb_sync/20210221-070421
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f40ddce88593482919761f74910f42f4b84c004b
config: i386-randconfig-s002-20210221 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-229-g60c1f270-dirty
        # https://github.com/0day-ci/linux/commit/77b85e0ba17f78b0335bf283901691ec3942dec3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tong-Zhang/video-fbdev-pm2fb-avoid-stall-on-fb_sync/20210221-070421
        git checkout 77b85e0ba17f78b0335bf283901691ec3942dec3
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

>> drivers/video/fbdev/pm2fb.c:193:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     193 | static int inline void WAIT_FIFO_TIMEOUT(struct pm2fb_par *p, u32 a)
         | ^~~~~~
>> drivers/video/fbdev/pm2fb.c:193:19: error: two or more data types in declaration specifiers
     193 | static int inline void WAIT_FIFO_TIMEOUT(struct pm2fb_par *p, u32 a)
         |                   ^~~~


vim +193 drivers/video/fbdev/pm2fb.c

   183	
   184	#ifdef CONFIG_FB_PM2_FIFO_DISCONNECT
   185	#define WAIT_FIFO(p, a)
   186	#define WAIT_FIFO_TIMEOUT(p, a) (0)
   187	#else
   188	static inline void WAIT_FIFO(struct pm2fb_par *p, u32 a)
   189	{
   190		while (pm2_RD(p, PM2R_IN_FIFO_SPACE) < a)
   191			cpu_relax();
   192	}
 > 193	static int inline void WAIT_FIFO_TIMEOUT(struct pm2fb_par *p, u32 a)
   194	{
   195		int timeout = 10000;
   196		while (pm2_RD(p, PM2R_IN_FIFO_SPACE) < a) {
   197			cpu_relax();
   198			if (--timeout==0)
   199				return 1;
   200		}
   201		return 0;
   202	}
   203	#endif
   204	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip