Re: [PATCH v1] Staging: rtl8192e: fix kconfig dependency on CRYPTO

[Greg KH]

On Sat, Feb 20, 2021 at 12:22:43PM -0500, Julian Braha wrote:
> >From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001
> From: Julian Braha <julianbraha@xxxxxxxxx>
> Date: Sat, 20 Feb 2021 12:07:30 -0500
> Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO

Why is this all in the body of the email?  Please just use 'git
send-email' to send the patch out, do not attach it all to the message
like this :(

> 
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
> 
> WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
>   Depends on [n]: CRYPTO [=n]
>   Selected by [m]:
>   - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
>   Depends on [n]: CRYPTO [=n]
>   Selected by [m]:
>   - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>   - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
> 
> This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and 
> CRYPTO_LIB_ARC4, without depending on or selecting CRYPTO, 
> despite those config options being subordinate to CRYPTO.

trailing whitespace in your commit log :(

thanks,

greg k-h