Re: [PATCH v5 22/22] arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISP

[Andrey Konovalov]

Hi Robert,

Thank you for your patch!

Reviewed-by: Andrey Konovalov <andrey.konovalov@xxxxxxxxxx>

Thanks,
Andrey

On 17.02.2021 14:21, Robert Foss wrote:
> Enable camss & ov8856 DT nodes.
>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> ---
>
> Changes since v1
>   - Laurent: Fix subject
>   - Laurent: Remove redundant regulator labels
>   - Laurent: Remove empty line
>
> Changes since v3
>   - Fixed ordering of IRQs
>   - Add newlines for better readability
>
>   arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 19 +++++++++++++++++--
>   1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 5842ab65789c..d89286f6aacb 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1108,6 +1108,21 @@ &cci {
>   
>   &camss {
>   	vdda-supply = <&vreg_l1a_0p875>;
> +
> +	status = "ok";
> +
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		port@0 {
> +			reg = <0>;
> +			csiphy0_ep: endpoint {
> +				clock-lanes = <1>;
> +				data-lanes = <1 2 3 4>;
> +				remote-endpoint = <&ov8856_ep>;
> +			};
> +		};
> +	};
>   };
>   
>   &cci_i2c0 {
> @@ -1139,7 +1154,7 @@ camera@10 {
>   		avdd-supply = <&cam0_avdd_2v8>;
>   		dvdd-supply = <&cam0_dvdd_1v2>;
>   
> -		status = "disable";
> +		status = "ok";
>   
>   		port {
>   			ov8856_ep: endpoint {
> @@ -1147,7 +1162,7 @@ ov8856_ep: endpoint {
>   				link-frequencies = /bits/ 64
>   					<360000000 180000000>;
>   				data-lanes = <1 2 3 4>;
> -//				remote-endpoint = <&csiphy0_ep>;
> +				remote-endpoint = <&csiphy0_ep>;
>   			};
>   		};
>   	};