Re: [PATCH] virtio: remove export for virtio_config_{enable, disable}

[Jason Wang]

On 2021/2/21 12:28 上午, Xianting Tian wrote:
> virtio_config_enable(), virtio_config_disable() are only used inside
> drivers/virtio/virtio.c, so it doesn't need export the symbols.
>
> Signed-off-by: Xianting Tian <xianting_tian@xxxxxxx>


Acked-by: Jason Wang <jasowang@xxxxxxxxxx>


> ---
>   drivers/virtio/virtio.c | 6 ++----
>   include/linux/virtio.h  | 2 --
>   2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index 42e09cc..4b15c00 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -141,15 +141,14 @@ void virtio_config_changed(struct virtio_device *dev)
>   }
>   EXPORT_SYMBOL_GPL(virtio_config_changed);
>   
> -void virtio_config_disable(struct virtio_device *dev)
> +static void virtio_config_disable(struct virtio_device *dev)
>   {
>   	spin_lock_irq(&dev->config_lock);
>   	dev->config_enabled = false;
>   	spin_unlock_irq(&dev->config_lock);
>   }
> -EXPORT_SYMBOL_GPL(virtio_config_disable);
>   
> -void virtio_config_enable(struct virtio_device *dev)
> +static void virtio_config_enable(struct virtio_device *dev)
>   {
>   	spin_lock_irq(&dev->config_lock);
>   	dev->config_enabled = true;
> @@ -158,7 +157,6 @@ void virtio_config_enable(struct virtio_device *dev)
>   	dev->config_change_pending = false;
>   	spin_unlock_irq(&dev->config_lock);
>   }
> -EXPORT_SYMBOL_GPL(virtio_config_enable);
>   
>   void virtio_add_status(struct virtio_device *dev, unsigned int status)
>   {
> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index 55ea329..b1894e0 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -132,8 +132,6 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)
>   void virtio_break_device(struct virtio_device *dev);
>   
>   void virtio_config_changed(struct virtio_device *dev);
> -void virtio_config_disable(struct virtio_device *dev);
> -void virtio_config_enable(struct virtio_device *dev);
>   int virtio_finalize_features(struct virtio_device *dev);
>   #ifdef CONFIG_PM_SLEEP
>   int virtio_device_freeze(struct virtio_device *dev);