RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

From: Li, Meng
Date: Mon Feb 22 2021 - 04:39:08 EST


Thanks for all of your comments.

Regards,
Limeng

> -----Original Message-----
> From: Lee Jones <lee.jones@xxxxxxxxxx>
> Sent: Monday, February 22, 2021 5:21 PM
> To: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Li, Meng <Meng.Li@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> arnd@xxxxxxxx; Hao, Kexin <Kexin.Hao@xxxxxxxxxxxxx>
> Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for
> regmap_config"
>
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> On Mon, 22 Feb 2021, Marc Zyngier wrote:
>
> > Hi Limeng,
> >
> > On 2021-02-22 03:45, Li, Meng wrote:
> > > Hi Marc&Lee,
> > >
> > > Is there any comment on this patch?
> > > Could you please help to review this patch so that I can improve it
> > > if it still has weakness?
> >
> > If you are confident that the root issue has been fixed, no objection
> > from me, but I'm not in a position to test it at the moment (the board
> > I found the problem on is in a bit of a state).
>
> I'm not keen on flip-flopping this patch in and out of the kernel.
> Someone really needs to spend some time to map out the full life-cycle and
> propose a (possibly cross-subsystem) solution.
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services Linaro.org │ Open source
> software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog