Re: [PATCH v4 1/4] PCI: Introduce pcim_alloc_irq_vectors()

From: Robert Richter
Date: Mon Feb 22 2021 - 06:01:11 EST


On 19.02.21 17:15:50, Krzysztof Wilczyński wrote:
> Hi Robert,
>
> [...]
> > Obiously this is meant here:
> >
> > if (!pci_is_managed(dev))
> [...]
>
> A question to improve my understanding for future reference. Was the
> previous approach of checking for "enabled" flag from struct pci_devres
> was not a good choice here?

Initially this was meant to just show the idea.

After careful review I don't see this additional check is required as
once the pci dev is managed, it will be always released with
pcim_release().

-Robert