Re: [PATCH v2 3/3] mm: Fix missing mem cgroup soft limit tree updates
From: Tim Chen
Date: Mon Feb 22 2021 - 12:47:08 EST
On 2/22/21 12:41 AM, Michal Hocko wrote:
>>
>>
>> Ah, that's true. The added check for soft_limit_excess is not needed.
>>
>> Do you think it is still a good idea to add patch 3 to
>> restrict the uncharge update in page batch of the same node and cgroup?
>
> I would rather drop it. The less the soft limit reclaim code is spread
> around the better.
>
Let's drop patch 3 then. I find patch 2 is the most critical one in this series.
Without that patch some cgroups exceeds the soft limit excess very badly.
Tim