Re: [PATCH 13/13] arm64: dts: qcom: sc7280: Add cpuidle states

[Maulik Shah]

Hi Stephen,

On 2/23/2021 1:19 PM, Stephen Boyd wrote:
> Quoting Rajendra Nayak (2021-02-11 23:28:50)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 8f2002b..3b86052 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -186,12 +207,69 @@
> >                          compatible = "arm,kryo";
> >                          reg = <0x0 0x700>;
> >                          enable-method = "psci";
> > +                       cpu-idle-states = <&BIG_CPU_SLEEP_0
> > +                                          &BIG_CPU_SLEEP_1
> > +                                          &CLUSTER_SLEEP_0>;
> >                          next-level-cache = <&L2_700>;
> >                          L2_700: l2-cache {
> >                                  compatible = "cache";
> >                                  next-level-cache = <&L3_0>;
> >                          };
> >                  };
> > +
> > +               idle-states {
> > +                       entry-method = "psci";
> > +
> > +                       LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 {
> > +                               compatible = "arm,idle-state";
> > +                               idle-state-name = "little-power-down";
> > +                               arm,psci-suspend-param = <0x40000003>;
> > +                               entry-latency-us = <549>;
> > +                               exit-latency-us = <901>;
> > +                               min-residency-us = <1774>;
> Are these preliminary numbers? They're the same as sc7180 from what I
> can tell, but presumably things changed between SoC versions?

yes they are preliminary numbers, we are yet to measure on sc7280 and 
will update later once measured.

Thanks,
Maulik
> > +                               local-timer-stop;
> > +                       };
> > +
> > +                       LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 {
> > +                               compatible = "arm,idle-state";
> > +                               idle-state-name = "little-rail-power-down";
> > +                               arm,psci-suspend-param = <0x40000004>;
> > +                               entry-latency-us = <702>;
> > +                               exit-latency-us = <915>;
> > +                               min-residency-us = <4001>;
> > +                               local-timer-stop;
> > +                       };
> > +
> > +                       BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
> > +                               compatible = "arm,idle-state";
> > +                               idle-state-name = "big-power-down";
> > +                               arm,psci-suspend-param = <0x40000003>;
> > +                               entry-latency-us = <523>;
> > +                               exit-latency-us = <1244>;
> > +                               min-residency-us = <2207>;

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation