Re: [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies
From: Robert Foss
Date: Tue Feb 23 2021 - 10:00:33 EST
Hey Hsin-Yi,
Thanks for the patch, and sorry about the delays in reviewing this.
This patch does not apply to the drm-misc/for-linux-next branch due to
some other changes having been merged.
On Sat, 20 Feb 2021 at 07:10, Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
>
> anx7625 requires 3 power supply regulators.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 60585a4fc22bc..3ae97d9523e56 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -34,6 +34,15 @@ properties:
> description: used for reset chip control, RESET_N pin B7.
> maxItems: 1
>
> + vdd10-supply:
> + description: Regulator that provides the supply 1.0V power.
> +
> + vdd18-supply:
> + description: Regulator that provides the supply 1.8V power.
> +
> + vdd33-supply:
> + description: Regulator that provides the supply 3.3V power.
> +
This chunk below has seen some changes.
With this patch fixed, feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>
> ports:
> type: object
>
> @@ -55,6 +64,9 @@ properties:
> required:
> - compatible
> - reg
> + - vdd10-supply
> + - vdd18-supply
> + - vdd33-supply
> - ports
>
> additionalProperties: false
> @@ -72,6 +84,9 @@ examples:
> reg = <0x58>;
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> + vdd10-supply = <&pp1000_mipibrdg>;
> + vdd18-supply = <&pp1800_mipibrdg>;
> + vdd33-supply = <&pp3300_mipibrdg>;
>
> ports {
> #address-cells = <1>;
> --
> 2.30.0.617.g56c4b15f3c-goog
>