Re: [PATCH] kdb: Remove redundant function definitions/prototypes

[Doug Anderson]

Hi,

On Tue, Feb 23, 2021 at 4:01 AM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
>
> @@ -103,7 +103,6 @@ extern int kdb_getword(unsigned long *, unsigned long, size_t);
>  extern int kdb_putword(unsigned long, unsigned long, size_t);
>
>  extern int kdbgetularg(const char *, unsigned long *);
> -extern int kdbgetu64arg(const char *, u64 *);

IMO you should leave kdbgetu64arg() the way it was.  It is symmetric
to all of the other similar functions and even if there are no
external users of kdbgetu64arg() now it seems like it makes sense to
keep it matching.


> @@ -209,9 +208,7 @@ extern unsigned long kdb_task_state(const struct task_struct *p,
>                                     unsigned long mask);
>  extern void kdb_ps_suppressed(void);
>  extern void kdb_ps1(const struct task_struct *p);
> -extern void kdb_print_nameval(const char *name, unsigned long val);
>  extern void kdb_send_sig(struct task_struct *p, int sig);
> -extern void kdb_meminfo_proc_show(void);

Getting rid of kdb_print_nameval() / kdb_meminfo_proc_show() makes sense to me.


>  extern char kdb_getchar(void);
>  extern char *kdb_getstr(char *, size_t, const char *);
>  extern void kdb_gdb_state_pass(char *buf);
> diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
> index 6226502ce049..b59aad1f0b55 100644
> --- a/kernel/debug/kdb/kdb_support.c
> +++ b/kernel/debug/kdb/kdb_support.c
> @@ -665,24 +665,6 @@ unsigned long kdb_task_state(const struct task_struct *p, unsigned long mask)
>         return (mask & kdb_task_state_string(state)) != 0;
>  }
>
> -/*
> - * kdb_print_nameval - Print a name and its value, converting the
> - *     value to a symbol lookup if possible.
> - * Inputs:
> - *     name    field name to print
> - *     val     value of field
> - */
> -void kdb_print_nameval(const char *name, unsigned long val)
> -{
> -       kdb_symtab_t symtab;
> -       kdb_printf("  %-11.11s ", name);
> -       if (kdbnearsym(val, &symtab))
> -               kdb_symbol_print(val, &symtab,
> -                                KDB_SP_VALUE|KDB_SP_SYMSIZE|KDB_SP_NEWLINE);
> -       else
> -               kdb_printf("0x%lx\n", val);
> -}
> -

Getting rid of kdb_print_nameval() makes sense to me.

-Doug