Re: [PATCH v26 0/5] Add initial zynqmp R5 remoteproc driver

From: Mathieu Poirier
Date: Tue Feb 23 2021 - 11:35:15 EST


Good morning,

I have received your patchset but currently don't see having the time
to look at it before the middle of March.

Thanks,
Mathieu

On Tue, 23 Feb 2021 at 08:44, Ben Levinsky <ben.levinsky@xxxxxxxxxx> wrote:
>
> R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this
> remotproc driver, we can boot the R5 sub-system in two different
> configurations -
> * Split
> * Lockstep
>
> The Xilinx R5 Remoteproc Driver boots the R5's via calls to the Xilinx
> Platform Management Unit that handles the R5 configuration, memory access
> and R5 lifecycle management. The interface to this manager is done in this
> driver via zynqmp_pm_* function calls.
>
> v26:
> - add prepare and unprepare to handle Xilinx platform management's
> request_node and release node using each core's list of srams
> that is constructed in each core's zynqmp_r5_probe.
> - add new field sram to zynqmp_r5_rproc to store each core's srams
> being used as described in device tree. This helps to reduce unneeded looping
> of the sram prop in device tree. As now only zynqmp_r5_probe has to parse
> and validate each core's sram property. The ensuing prepare, unprepare
> and parse_fw logic are now much simpler.
> - similarly add 'size' field to struct sram_addr_data to simplify
> prepare, unprepare and parse_fw.
>
> Previous version:
> https://patchwork.kernel.org/project/linux-remoteproc/list/?series=412083
>
>
> Ben Levinsky (5):
> firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU
> configuration.
> firmware: xilinx: Add shutdown/wakeup APIs
> firmware: xilinx: Add RPU configuration APIs
> dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc
> bindings
> remoteproc: Add initial zynqmp R5 remoteproc driver
>
> .../xilinx,zynqmp-r5-remoteproc.yaml | 223 ++++
> drivers/firmware/xilinx/zynqmp.c | 96 ++
> drivers/remoteproc/Kconfig | 8 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/zynqmp_r5_remoteproc.c | 954 ++++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 64 ++
> 6 files changed, 1356 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> create mode 100644 drivers/remoteproc/zynqmp_r5_remoteproc.c
>
> --
> 2.17.1
>