Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip
From: Krzysztof Kozlowski
Date: Tue Feb 23 2021 - 14:04:59 EST
On Tue, 23 Feb 2021 at 11:45, Adrien Grassein <adrien.grassein@xxxxxxxxx> wrote:
> > > >
> > > > I would assume this goes from PMIC, so check your schematics. There is
> > > > little point in adding a fixed regulator which is non-controllable.
> > >
> > > No, the 1.8V is issued directly from the alimentation stage.
> > > So we can't control it.
> > >
> > > > I think bindings don't require it.
> > > After reading some code, I can say that vqmmc is not mandatory but it
> > > helped to find out
> > > the caps of the mmc host. In this case, we only support 1.8V on vqmmc.
> > > It avoids driver to guess it (and avoid bad behaviour on any future change).
> >
> > If the supply (hardware) is really 1.8 V then indeed your approach is
> > good. So let's keep that one.
> >
>
> To be sure to understand well: should I keep the fixed regulator?
> Thanks,
Yes, keep it, at least I am fine with it.
Best regards,
Krzysztof