Re: [PATCH 1/3] kbuild: Make old-atomics and missing-syscalls phony targets

[Masahiro Yamada]

On Wed, Feb 24, 2021 at 3:14 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> The old-atomics and missing-syscalls targets are not files, so they
> should be marked as PHONY.
>
> Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Cc: Michal Marek <michal.lkml@xxxxxxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  Kbuild | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Kbuild b/Kbuild
> index fa441b98c9f6..032157c3ffd2 100644
> --- a/Kbuild
> +++ b/Kbuild
> @@ -44,6 +44,7 @@ always-y += missing-syscalls
>  quiet_cmd_syscalls = CALL    $<
>        cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags)
>
> +PHONY += missing-syscalls
>  missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
>         $(call cmd,syscalls)
>
> @@ -55,5 +56,6 @@ always-y += old-atomics
>  quiet_cmd_atomics = CALL    $<
>        cmd_atomics = $(CONFIG_SHELL) $<
>
> +PHONY += old-atomics


I do not think this is the right fix.

always-y (specified a few lines above) adds $(obj)/ prefix,
and is not supposed to work with PHONY.


It is wrong to blindly eliminate
the errors detected by your 3/3



>  old-atomics: scripts/atomic/check-atomics.sh FORCE
>         $(call cmd,atomics)
> --
> 2.27.0
>


-- 
Best Regards
Masahiro Yamada