Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function

[Lakshmi Ramasubramanian]

On 2/23/21 5:20 PM, Thiago Jung Bauermann wrote:
> Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx> writes:
>
> > From: Rob Herring <robh@xxxxxxxxxx>
> >
> > Both arm64 and powerpc do essentially the same FDT /chosen setup for
> > kexec.  The differences are either omissions that arm64 should have
> > or additional properties that will be ignored.  The setup code can be
> > combined and shared by both powerpc and arm64.
> >
> > The differences relative to the arm64 version:
> >   - If /chosen doesn't exist, it will be created (should never happen).
> >   - Any old dtb and initrd reserved memory will be released.
> >   - The new initrd and elfcorehdr are marked reserved.
> >   - "linux,booted-from-kexec" is set.
> >
> > The differences relative to the powerpc version:
> >   - "kaslr-seed" and "rng-seed" may be set.
> >   - "linux,elfcorehdr" is set.
> >   - Any existing "linux,usable-memory-range" is removed.
> >
> > Combine the code for setting up the /chosen node in the FDT and updating
> > the memory reservation for kexec, for powerpc and arm64, in
> > of_kexec_alloc_and_setup_fdt() and move it to "drivers/of/kexec.c".
> >
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx>
> > Fixes: 33488dc4d61f ("of: Add a common kexec FDT setup function")
>
> A patch cannot fix itself. The world would be a much better place if it
> could. :-)

:)

> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > ---
> >   drivers/of/Makefile |   6 +
> >   drivers/of/kexec.c  | 265 ++++++++++++++++++++++++++++++++++++++++++++
> >   include/linux/of.h  |   5 +
> >   3 files changed, 276 insertions(+)
> >   create mode 100644 drivers/of/kexec.c
>
> With that fixed:
>
> Reviewed-by: Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxx>

Thanks for reviewing the patches Thiago.

 -lakshmi