Re: (.text.ks8851_probe_common+0x370): undefined reference to `__this_module'

[Randy Dunlap]

On 2/21/21 10:12 PM, kernel test robot wrote:
> Hi Marek,
>
> FYI, the error/warning still remains.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   31caf8b2a847214be856f843e251fc2ed2cd1075
> commit: ef3631220d2b3d8d14cf64464760505baa60d6ac net: ks8851: Register MDIO bus and the internal PHY
> date:   7 weeks ago
> config: parisc-randconfig-r034-20210222 (attached as .config)
> compiler: hppa-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef3631220d2b3d8d14cf64464760505baa60d6ac
>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>          git fetch --no-tags linus master
>          git checkout ef3631220d2b3d8d14cf64464760505baa60d6ac
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
>     hppa-linux-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common':
> > > (.text.ks8851_probe_common+0x370): undefined reference to `__this_module'
> > > hppa-linux-ld: (.text.ks8851_probe_common+0x374): undefined reference to `__this_module'

Hey Arnd-

I wanted to see if you had any ideas about this problem.

CONFIG_KS8851=y
CONFIG_KS8851_MLL=m

The problem is that 2 drivers share some common code, but in one case
the shared code is builtin and for the other driver it is a loadable
module. The common code is first built as builtin, so it does not have
the "__this_module" symbol.

Thanks.