Re: [PATCH -next] sound: n64: Fix return value check in n64audio_probe()

[Lauri Kasanen]

On Wed, 24 Feb 2021 01:38:03 +0000
Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:

> In case of error, the function devm_platform_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: 1448f8acf4cc ("sound: Add n64 driver")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  sound/mips/snd-n64.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Lauri Kasanen <cand@xxxxxxx>

- Lauri