Re: [PATCH] sound/usb generate midi streaming substream names from jack names

[Takashi Iwai]

On Sun, 21 Feb 2021 10:43:32 +0100,
George Harker wrote:
> 
> A number of devices have named substreams which are hard to remember /
> decypher from <device> MIDI n names.  Eg. Korg puts a pass through on
> one substream and iConnectivity devices name the connections.
> 
> This makes it easier to connect to the correct device.  Devices which
> handle naming through quirks are unaffected by this change.
> 
> Addresses TODO comment in sound/usb/midi.c
> 
> Signed-off-by: George Harker <george@xxxxxxxxxxxxxxxxxxxxx>

The code changes look almost OK, but could you try the following?

- Split the patch: one for rewriting with the structs in
  linux/usb/midi.h, another for adding the MIDI device name support

- Try to avoid magic numbers: a few places should be replaced with
  sizeof() or ARRAY_SIZE().


thanks,

Takashi