Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer

[Stefano Garzarella]

On Wed, Feb 24, 2021 at 09:29:54AM +0100, Pavel Machek wrote:
> Hi!
>
> > >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > >>@@ -42,6 +42,8 @@ static char *macaddr;
> > >> module_param(macaddr, charp, 0);
> > >> MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
> > >>
> > >>+u8 macaddr_buf[ETH_ALEN];
> > >>+
> > >
> > >Should this be static?
> >
> > Yes, there is already a patch [1] queued by Michael but not yet upstream.
> > When it will be merged upstream I will make sure it will be backported.
>
> Having it in mainline is enough, I don't really think it causes
> anything user-visible, so it does not need to be in stable.

Got it.

Thanks,
Stefano