Re: [PATCH v4 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet

From: Maxime Ripard
Date: Wed Feb 24 2021 - 05:11:50 EST

Hi,

We're almost there, except for ...

On Mon, Feb 22, 2021 at 11:08:26AM +0100, Pascal Roeleven wrote:
> +&lradc {
> + vref-supply = <&reg_ldo2>;
> + status = "okay";
> +
> + button-761 {
> + label = "Volume Down";
> + linux,code = <KEY_VOLUMEDOWN>;
> + channel = <0>;
> + voltage = <761904>;
> + };
> +
> + button-571 {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + channel = <0>;
> + voltage = <571428>;
> + };
> +};

Those nodes should be ordered alphabetically

Maxime

Attachment: signature.asc
Description: PGP signature