Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC

From: Miquel Raynal
Date: Thu Feb 25 2021 - 02:49:36 EST


Hi Álvaro,

Brian Norris <computersforpeace@xxxxxxxxx> wrote on Wed, 24 Feb 2021
13:01:13 -0800:

> On Wed, Feb 24, 2021 at 12:02 AM Álvaro Fernández Rojas
> <noltari@xxxxxxxxx> wrote:
> > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
>
> FWIW, I could believe this was broken. We weren't testing Hamming ECC
> (nor JFFS2) at the time, so it could easily have obvious bugs like
> this.

Right, you should probably limit the backport to the time when raw
accessors got introduced/fixed.

Thanks,
Miquèl