drivers/staging/qlge/qlge_main.c:4564 qlge_probe() warn: missing error code 'err'

From: Dan Carpenter
Date: Thu Feb 25 2021 - 05:32:24 EST

Next message: Previous message:
Messages sorted by:
tree: .config.gz Description: application/gzip href="01445.html"> Lee Gibson: "[PATCH] staging: rtl8192u: minor coding style fix" Greg Kroah-Hartman: "[PATCH 5.4 00/17] 5.4.101-rc1 review" href="date.html#01444">[ date ] [ thread ] [ subject ] [ author ] rnel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
7
staging: qlge: Initialize devlink health dump framework
(attached as .config)
tag as appropriate
x>
xxxxxxxx>
qlge_probe() warn: missing error code 'err'
c
Bill Pemberton 2012-12-03 4544 static int qlge_probe(struct pci_dev *pdev,
Ron Mercer 2008-09-18 4545 const struct pci_device_id *pci_entry)
Ron Mercer 2008-09-18 4546 {
Coiby Xu 2021-01-23 4547 struct qlge_netdev_priv *ndev_priv;
Coiby Xu 2021-01-23 4548 struct qlge_adapter *qdev = NULL;
Coiby Xu 2021-01-23 4549 struct net_device *ndev = NULL;
Coiby Xu 2021-01-23 4550 struct devlink *devlink;
Dorothea Ehrl 2019-11-27 4551 static int cards_found;
Ron Mercer 2008-09-18 4552 int err = 0;
Ron Mercer 2008-09-18 4553
Coiby Xu 2021-01-23 4554 devlink = devlink_alloc(&qlge_devlink_ops, sizeof(struct qlge_adapter));
Coiby Xu 2021-01-23 4555 if (!devlink)
Coiby Xu 2021-01-23 4556 return -ENOMEM;
Coiby Xu 2021-01-23 4557
Coiby Xu 2021-01-23 4558 qdev = devlink_priv(devlink);
Coiby Xu 2021-01-23 4559
Coiby Xu 2021-01-23 4560 ndev = alloc_etherdev_mq(sizeof(struct qlge_netdev_priv),
Scott Schafer 2019-12-11 4561 min(MAX_CPUS,
Scott Schafer 2019-12-11 4562 netif_get_num_default_rss_queues()));
Ron Mercer 2008-09-18 4563 if (!ndev)
Coiby Xu 2021-01-23 @4564 goto devlink_free;
Ron Mercer 2008-09-18 4565
Coiby Xu 2021-01-23 4566 ndev_priv = netdev_priv(ndev);
Coiby Xu 2021-01-23 4567 ndev_priv->qdev = qdev;
Coiby Xu 2021-01-23 4568 ndev_priv->ndev = ndev;
Coiby Xu 2021-01-23 4569 qdev->ndev = ndev;
Coiby Xu 2021-01-23 4570 err = qlge_init_device(pdev, qdev, cards_found);
Coiby Xu 2021-01-23 4571 if (err < 0)
Coiby Xu 2021-01-23 4572 goto netdev_free;
Ron Mercer 2008-09-18 4573
Ron Mercer 2008-09-18 4574 SET_NETDEV_DEV(ndev, &pdev->dev);
Jitendra Kalsaria 2013-09-27 4575 ndev->hw_features = NETIF_F_SG |
Jitendra Kalsaria 2013-09-27 4576 NETIF_F_IP_CSUM |
Jitendra Kalsaria 2013-09-27 4577 NETIF_F_TSO |
Jitendra Kalsaria 2013-09-27 4578 NETIF_F_TSO_ECN |
Jitendra Kalsaria 2013-09-27 4579 NETIF_F_HW_VLAN_CTAG_TX |
Jitendra Kalsaria 2013-09-27 4580 NETIF_F_HW_VLAN_CTAG_RX |
Jitendra Kalsaria 2013-09-27 4581 NETIF_F_HW_VLAN_CTAG_FILTER |
Jitendra Kalsaria 2013-09-27 4582 NETIF_F_RXCSUM;
Jitendra Kalsaria 2013-09-27 4583 ndev->features = ndev->hw_features;
brenohl@xxxxxxxxxx 2012-07-27 4584 ndev->vlan_features = ndev->hw_features;
Jitendra Kalsaria 2014-01-14 4585 /* vlan gets same features (except vlan filter) */
Vlad Yasevich 2014-03-27 4586 ndev->vlan_features &= ~(NETIF_F_HW_VLAN_CTAG_FILTER |
Vlad Yasevich 2014-03-27 4587 NETIF_F_HW_VLAN_CTAG_TX |
Vlad Yasevich 2014-03-27 4588 NETIF_F_HW_VLAN_CTAG_RX);
Ron Mercer 2008-09-18 4589
Ron Mercer 2008-09-18 4590 if (test_bit(QL_DMA64, &qdev->flags))
Ron Mercer 2008-09-18 4591 ndev->features |= NETIF_F_HIGHDMA;
Ron Mercer 2008-09-18 4592
Ron Mercer 2008-09-18 4593 /*
Ron Mercer 2008-09-18 4594 * Set up net_device structure.
Ron Mercer 2008-09-18 4595 */
Ron Mercer 2008-09-18 4596 ndev->tx_queue_len = qdev->tx_ring_size;
Ron Mercer 2008-09-18 4597 ndev->irq = pdev->irq;
Stephen Hemminger 2008-11-21 4598
Stephen Hemminger 2008-11-21 4599 ndev->netdev_ops = &qlge_netdev_ops;
Wilfried Klaebe 2014-05-11 4600 ndev->ethtool_ops = &qlge_ethtool_ops;
Ron Mercer 2008-09-18 4601 ndev->watchdog_timeo = 10 * HZ;
Stephen Hemminger 2008-11-21 4602
Jarod Wilson 2016-10-20 4603 /* MTU range: this driver only supports 1500 or 9000, so this only
Jarod Wilson 2016-10-20 4604 * filters out values above or below, and we'll rely on
Jarod Wilson 2016-10-20 4605 * qlge_change_mtu to make sure only 1500 or 9000 are allowed
Jarod Wilson 2016-10-20 4606 */
Jarod Wilson 2016-10-20 4607 ndev->min_mtu = ETH_DATA_LEN;
Jarod Wilson 2016-10-20 4608 ndev->max_mtu = 9000;
Jarod Wilson 2016-10-20 4609
Ron Mercer 2008-09-18 4610 err = register_netdev(ndev);
Ron Mercer 2008-09-18 4611 if (err) {
Ron Mercer 2008-09-18 4612 dev_err(&pdev->dev, "net device registration failed.\n");
Coiby Xu 2021-01-23 4613 qlge_release_all(pdev);
Ron Mercer 2008-09-18 4614 pci_disable_device(pdev);
Coiby Xu 2021-01-23 4615 goto netdev_free;
Ron Mercer 2008-09-18 4616 }
Coiby Xu 2021-01-23 4617
Coiby Xu 2021-01-23 4618 err = devlink_register(devlink, &pdev->dev);
Coiby Xu 2021-01-23 4619 if (err)
Coiby Xu 2021-01-23 4620 goto netdev_free;
Coiby Xu 2021-01-23 4621
Coiby Xu 2021-01-23 4622 qlge_health_create_reporters(qdev);
Ron Mercer 2010-02-04 4623 /* Start up the timer to trigger EEH if
Ron Mercer 2010-02-04 4624 * the bus goes dead
Ron Mercer 2010-02-04 4625 */
Coiby Xu 2021-01-23 4626 timer_setup(&qdev->timer, qlge_timer, TIMER_DEFERRABLE);
Kees Cook 2017-10-04 4627 mod_timer(&qdev->timer, jiffies + (5 * HZ));
Coiby Xu 2021-01-23 4628 qlge_link_off(qdev);
Coiby Xu 2021-01-23 4629 qlge_display_dev_info(ndev);
Ron Mercer 2009-10-30 4630 atomic_set(&qdev->lb_count, 0);
Ron Mercer 2008-09-18 4631 cards_found++;
Ron Mercer 2008-09-18 4632 return 0;
Coiby Xu 2021-01-23 4633
Coiby Xu 2021-01-23 4634 netdev_free:
Coiby Xu 2021-01-23 4635 free_netdev(ndev);
Coiby Xu 2021-01-23 4636 devlink_free:
Coiby Xu 2021-01-23 4637 devlink_free(devlink);
Coiby Xu 2021-01-23 4638
Coiby Xu 2021-01-23 4639 return err;
Ron Mercer 2008-09-18 4640 }

yperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
- Next message: Lee Gibson: "[PATCH] staging: rtl8192u: minor coding style fix"
- Previous message: Greg Kroah-Hartman: "[PATCH 5.4 00/17] 5.4.101-rc1 review"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]