Re: [PATCH] qtnfmac: remove meaningless goto statement and labels
From: wengjianfeng
Date: Thu Feb 25 2021 - 06:21:13 EST
On Thu, 25 Feb 2021 12:22:54 +0200
Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> kernel test robot <lkp@xxxxxxxxx> writes:
>
> > Hi samirweng1979,
> >
> > Thank you for the patch! Yet something to improve:
> >
> > [auto build test ERROR on wireless-drivers-next/master]
> > [also build test ERROR on wireless-drivers/master sparc-next/master
> > v5.11 next-20210225] [If your patch is applied to the wrong git
> > tree, kindly drop us a note. And when submitting patch, we suggest
> > to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch]
> >
> > url:
> > https://github.com/0day-ci/linux/commits/samirweng1979/qtnfmac-remove-meaningless-goto-statement-and-labels/20210225-145714
> > base:
> > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
> > master config: x86_64-randconfig-a001-20210225 (attached
> > as .config) compiler: clang version 13.0.0
> > (https://github.com/llvm/llvm-project
> > a921aaf789912d981cbb2036bdc91ad7289e1523) reproduce (this is a W=1
> > build): wget
> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> > -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64
> > cross compiling tool for clang build # apt-get install
> > binutils-x86-64-linux-gnu #
> > https://github.com/0day-ci/linux/commit/d18bea1fd25dee219ae56343ff9caf9cb6eb1519
> > git remote add linux-review https://github.com/0day-ci/linux git
> > fetch --no-tags linux-review
> > samirweng1979/qtnfmac-remove-meaningless-goto-statement-and-labels/20210225-145714
> > git checkout d18bea1fd25dee219ae56343ff9caf9cb6eb1519 # save the
> > attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
> > ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All errors (new ones prefixed by >>):
> >
> >>> drivers/net/wireless/quantenna/qtnfmac/commands.c:1901:8: error:
> >>> use of undeclared label 'out'
> > goto out;
>
> Do you compile test your patches? This error implies that not.
> Compilation test is a hard requirement for patches.
>
Hikvalo,
I'm sorry for make this mistake, and I will compile success before
send patch later. thanks.