Re: [PATCH] printk: clarify the documentation for plain pointer printing

From: Matthew Wilcox
Date: Thu Feb 25 2021 - 11:56:37 EST


On Thu, Feb 25, 2021 at 05:46:39PM +0100, Vlastimil Babka wrote:
> We have several modifiers for plain pointers (%p, %px and %pK) and now also
> the no_hash_pointers boot parameter. The documentation should help to choose
> which variant to use. Importantly, we should discourage %px in favour of %p
> (with the new boot parameter when debugging), and stress that %pK should be
> only used for procfs and similar files, not dmesg buffer. This patch clarifies
> the documentation in that regard.
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>

Really nice job.

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>