Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown

[Konrad Dybcio]

Hi,


>  
> +&pri_mi2s_active {
> +	pinconf {
> +		pins = "gpio53", "gpio54", "gpio55", "gpio56";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +};
> +

You can omit pinconf{}, so the outcome would be:
&pri_mi2s_active {

    pins = ...

    ...

};


This makes the DTs ever so shorter and is the style that's currently used for new submissions.

Same goes for the nodes that are being referenced.


> +&pri_mi2s_mclk_active {
> +	pinconf {
> +		pins = "gpio57";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +};
> +
>  &qspi_cs0 {
>  	pinconf {
>  		pins = "gpio68";
> @@ -1015,6 +1031,14 @@ pinconf-rx {
>  	};
>  };
>  
> +&sec_mi2s_active {
> +	pinconf {
> +		pins = "gpio49", "gpio50", "gpio51";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +};
> +
>  /* PINCTRL - board-specific pinctrl */
>  
>  &pm6150_gpio {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 60248a6757d8..5040923a9f7c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1856,12 +1856,6 @@ pinmux {
>  					pins = "gpio49", "gpio50", "gpio51";
>  					function = "mi2s_1";
>  				};
> -
> -				pinconf {
> -					pins = "gpio49", "gpio50", "gpio51";
> -					drive-strength = <8>;
> -					bias-pull-up;
> -				};
>  			};
>  
>  			pri_mi2s_active: pri-mi2s-active {
> @@ -1869,12 +1863,6 @@ pinmux {
>  					pins = "gpio53", "gpio54", "gpio55", "gpio56";
>  					function = "mi2s_0";
>  				};
> -
> -				pinconf {
> -					pins = "gpio53", "gpio54", "gpio55", "gpio56";
> -					drive-strength = <8>;
> -					bias-pull-up;
> -				};
>  			};
>  
>  			pri_mi2s_mclk_active: pri-mi2s-mclk-active {
> @@ -1882,12 +1870,6 @@ pinmux {
>  					pins = "gpio57";
>  					function = "lpass_ext";
>  				};
> -
> -				pinconf {
> -					pins = "gpio57";
> -					drive-strength = <8>;
> -					bias-pull-up;
> -				};
>  			};
>  
>  			sdc1_on: sdc1-on {
>
Applies to all ^.


Konrad