Re: [PATCH v8 1/1] mm/page_alloc.c: refactor initialization of struct page for holes in memory layout

[Mike Rapoport]

On Thu, Feb 25, 2021 at 04:08:51PM -0800, Andrew Morton wrote:
> On Fri, 26 Feb 2021 00:43:51 +0200 Mike Rapoport <rppt@xxxxxxxxxx> wrote:
> 
> > From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> 
> >  void __meminit __weak memmap_init_zone(struct zone *zone)
> >  {
> >  	unsigned long zone_start_pfn = zone->zone_start_pfn;
> >  	unsigned long zone_end_pfn = zone_start_pfn + zone->spanned_pages;
> >  	int i, nid = zone_to_nid(zone), zone_id = zone_idx(zone);
> > +	static unsigned long hole_pfn = 0;
> 
> static implies that pgdat->node_zones[] is alwyas sorted in ascending
> pfn order.  Always true?

Yes.

-- 
Sincerely yours,
Mike.