Re: [PATCH v2] media: exynos4-is: add missing call to of_node_put()

From: Krzysztof Kozlowski
Date: Fri Feb 26 2021 - 05:30:43 EST


On Fri, 26 Feb 2021 at 02:28, Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:
>
> In one of the error paths of the for_each_child_of_node() loop in
> fimc_md_parse_one_endpoint, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
> Function "for_each_child_of_node" should have of_node_put() before
> return around line 492.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>

You ignored the comment for this. Anyone can run Coccinelle and it
does not equal "Reported-by" credit. Reported by is for reported bugs,
but I asked three times to you guys to share the reports. This is not
an open way of working.

This should be removed.

Best regards,
Krzysztof