Re: [PATCH 2/5] ARM: dts: stm32: Add Engicam MicroGEA STM32MP1 SoM

[Alexandre TORGUE]

Hi Jagan

On 2/24/21 7:05 PM, Jagan Teki wrote:
> On Mon, Jan 25, 2021 at 8:35 PM Alexandre TORGUE
> <alexandre.torgue@xxxxxxxxxxx> wrote:
> > Hi,
> >
> > On 12/23/20 8:13 PM, Jagan Teki wrote:
> > > MicroGEA STM32MP1 is an EDIMM SoM based on STM32MP157A from Engicam.
> > >
> > > General features:
> > > - STM32MP157AAC
> > > - Up to 1GB DDR3L-800
> > > - 512MB Nand flash
> > > - I2S
> > >
> > > MicroGEA STM32MP1 needs to mount on top of Engicam MicroDev carrier
> > > boards for creating complete platform solutions.
> > >
> > > Add support for it.
> > >
> > > Signed-off-by: Matteo Lisi <matteo.lisi@xxxxxxxxxxx>
> > > Signed-off-by: Francesco Utel <francesco.utel@xxxxxxxxxxx>
> > > Signed-off-by: Mirko Ardinghi <mirko.ardinghi@xxxxxxxxxxx>
> > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >    .../dts/stm32mp157a-microgea-stm32mp1.dtsi    | 147 ++++++++++++++++++
> > >    1 file changed, 147 insertions(+)
> > >    create mode 100644 arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi
> > >
> > > diff --git a/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi
> > > new file mode 100644
> > > index 000000000000..97d569107bfe
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1.dtsi
> > > @@ -0,0 +1,147 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> > > +/*
> > > + * Copyright (c) STMicroelectronics 2019 - All Rights Reserved
> > > + * Copyright (c) 2020 Engicam srl
> > > + * Copyright (c) 2020 Amarula Solutons(India)
> > > + */
> > > +
> >
> > If STM32MP157AAC is soldered onto this board, you should include SoC
> > dtsi here and no into MicroDev 2.0 board. No ?
>
> No, it's an SoM dtsi. and it can be associated with the respective
> carrier board and include files are attached in its dts.
>
> Please check the next patches on this series.
Ok, I thought it was a mistake as you mentioned "- STM32MP157AAC" in 
your commit message.

regards
alex



> Jagan.