Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines
From: Shuah Khan
Date: Fri Feb 26 2021 - 13:17:47 EST
On 2/26/21 11:03 AM, Johannes Berg wrote:
@@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map *lock, int read)
/* avoid false negative lockdep_assert_not_held()
* and lockdep_assert_held()
*/
- return -1;
+ return LOCK_STATE_UNKNOWN;
I'd argue that then the other two return places here should also be
changed.
Makes sense.
Since lock_is_held_type() simply returns what __lock_is_held() for the
other cases, __lock_is_held() is the one that needs changes to use these
defines.
thanks,
-- Shuah