Re: [PATCH] perf trace: Ensure read cmdlines are null terminated.

[Namhyung Kim]

Hi Ian,

On Sat, Feb 27, 2021 at 7:14 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Issue detected by address sanitizer.
>
> Fixes: cd4ceb63438e (perf util: Save pid-cmdline mapping into tracing header)
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung

> ---
>  tools/perf/util/trace-event-read.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
> index f507dff713c9..8a01af783310 100644
> --- a/tools/perf/util/trace-event-read.c
> +++ b/tools/perf/util/trace-event-read.c
> @@ -361,6 +361,7 @@ static int read_saved_cmdline(struct tep_handle *pevent)
>                 pr_debug("error reading saved cmdlines\n");
>                 goto out;
>         }
> +       buf[ret] = '\0';
>
>         parse_saved_cmdline(pevent, buf, size);
>         ret = 0;
> --
> 2.30.1.766.gb4fecdf3b7-goog
>