Re: Re: [PATCH] tpm: Add missing check in tpm_inf_recv

From: dinghao . liu
Date: Mon Mar 01 2021 - 06:32:38 EST




"Jarkko Sakkinen" <jarkko@xxxxxxxxxx>写道:
> On Sun, Feb 28, 2021 at 05:32:30PM +0800, Dinghao Liu wrote:
> > The use of wait() in tpm_inf_recv() is almost the same. It's odd that
> > we only check the return value and terminate execution flow of one call.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
>
> Is the unchecked return value of wait() the problem? I don't see the
> function even mentioned in the description.
>

Yes. This issue is reported by my static analysis tool. I think we
should treat wait() equally in this function (check the return value
and return an error code on failure).

Regards,
Dinghao