Re: [PATCH V2] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

[Christophe Leroy]

Le 02/03/2021 à 07:37, Anshuman Khandual a écrit :
> On 3/2/21 11:13 AM, Christophe Leroy wrote:
> > Le 02/03/2021 à 06:13, Anshuman Khandual a écrit :
> > > HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual
> > > platform subscribing it. Instead just make it generic.
> > >
> > > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Cc: Christoph Hellwig <hch@xxxxxx>
> > > Cc: linux-ia64@xxxxxxxxxxxxxxx
> > > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> > > Cc: linux-mm@xxxxxxxxx
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > > Suggested-by: Christoph Hellwig <hch@xxxxxx>
> > > Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> > > ---
> > > This change was originally suggested in an earilier discussion. This
> > > applies on v5.12-rc1 and has been build tested on all applicable
> > > platforms i.e ia64 and powerpc.
> > >
> > > https://patchwork.kernel.org/project/linux-mm/patch/1613024531-19040-3-git-send-email-anshuman.khandual@xxxxxxx/
> > >
> > > Changes in V2:
> > >
> > > - Added a description for HUGETLB_PAGE_SIZE_VARIABLE
> >
> > You are doing more than adding a description: you are making it user selectable. Is that what you want ?
>
> No, this was unintended. Will drop that description.

The description in the help section is OK.

It is only the text after the "bool" that makes it selectable.

	bool "Allows dynamic pageblock_order"