Re: [PATCH] Squashfs: fix xattr id and id lookup sanity checks

From: Phillip Lougher
Date: Wed Mar 03 2021 - 06:32:07 EST



> On 03/03/2021 00:34 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>
> On Mon, 1 Mar 2021 07:27:57 +0000 (GMT) Phillip Lougher <phillip@xxxxxxxxxxxxxxx> wrote:
>
> > The checks for maximum metadata block size is
> > missing SQUASHFS_BLOCK_OFFSET (the two byte length
> > count).
>
> What are the user visible consequences of this bug?

The user will be unable to mount the filesystem, because it will
fail the sanity check.


>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Phillip Lougher <phillip@xxxxxxxxxxxxxxx>
>
> Fixes: f37aa4c7366e23f ("squashfs: add more sanity checks in id lookup")
>
> yes?

Yes.

Phillip