Re: [PATCH] drm/msm/dsi: support CPHY mode for 7nm pll/phy

[Jonathan Marek]

On 3/5/21 4:48 PM, Rob Herring wrote:
> On Mon, Feb 15, 2021 at 11:27:44AM -0500, Jonathan Marek wrote:
> > Add the required changes to support 7nm pll/phy in CPHY mode.
> >
> > This adds a "qcom,dsi-phy-cphy-mode" property for the PHY node to enable
> > the CPHY mode.
> >
> > Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> > ---
> >   .../devicetree/bindings/display/msm/dsi.txt   |  1 +
> >   drivers/gpu/drm/msm/dsi/dsi.c                 | 12 +--
> >   drivers/gpu/drm/msm/dsi/dsi.h                 |  6 +-
> >   drivers/gpu/drm/msm/dsi/dsi.xml.h             |  2 +
> >   drivers/gpu/drm/msm/dsi/dsi_host.c            | 34 +++++--
> >   drivers/gpu/drm/msm/dsi/phy/dsi_phy.c         | 49 +++++++++-
> >   drivers/gpu/drm/msm/dsi/phy/dsi_phy.h         |  3 +
> >   drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c     | 89 ++++++++++++++-----
> >   drivers/gpu/drm/msm/dsi/pll/dsi_pll.c         |  4 +-
> >   drivers/gpu/drm/msm/dsi/pll/dsi_pll.h         |  5 +-
> >   drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c     | 71 +++++++++------
> >   11 files changed, 210 insertions(+), 66 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt
> > index b9a64d3ff184..7ffc86a9816b 100644
> > --- a/Documentation/devicetree/bindings/display/msm/dsi.txt
> > +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt
> > @@ -124,6 +124,7 @@ Required properties:
> >   Optional properties:
> >   - qcom,dsi-phy-regulator-ldo-mode: Boolean value indicating if the LDO mode PHY
> >     regulator is wanted.
> > +- qcom,dsi-phy-cphy-mode: Boolean value indicating if CPHY mode is wanted.
>
> This is board or SoC dependent? The latter should be implied by an SoC
> specific compatible.

It is board specific, 7nm dsi phy can operate in either D-PHY or C-PHY mode.