Re: [PATCH 1/3] dt-bindings/timer: ingenic: Add compatible strings for JZ4760(B)

[Paul Cercueil]

Le lun. 8 mars 2021 à 10:39, Rob Herring <robh@xxxxxxxxxx> a écrit :
> On Sun, 07 Mar 2021 17:15:51 +0000, Paul Cercueil wrote:
> >  Add compatible strings to support the system timer, clocksource, 
> > OST,
> >  watchdog and PWM blocks of the JZ4760 and JZ4760B SoCs.
> >
> >  Newer SoCs which behave like the JZ4760 or JZ4760B now see their
> >  compatible string require a fallback compatible string that 
> > corresponds
> >  to one of these two SoCs.
> >
> >  Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> >  ---
> >   .../bindings/timer/ingenic,tcu.yaml           | 28 
> > ++++++++++++++-----
> >   1 file changed, 21 insertions(+), 7 deletions(-)
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/timer/ingenic,tcu.yaml:62:13: 
> [warning] wrong indentation: expected 14 but found 12 (indentation)
> ./Documentation/devicetree/bindings/timer/ingenic,tcu.yaml:201:17: 
> [warning] wrong indentation: expected 18 but found 16 (indentation)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,tcu.example.dt.yaml: 
> timer@10002000: timer@e0:compatible: 'oneOf' conditional failed, one 
> must be fixed:
> 	['ingenic,jz4770-ost'] is too short
> 	'ingenic,jz4770-ost' is not one of ['ingenic,jz4725b-ost', 
> 'ingenic,jz4760b-ost']
> 	'ingenic,jz4760-ost' was expected
> 	From schema: 
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml

Totally my fault, looks like I didn't check the bindings before sending 
the patchset. I'll V2.

-Paul

> See https://patchwork.ozlabs.org/patch/1448709
>
> This check can fail if there are any dependencies. The base for a 
> patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up 
> to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.